Initial setup for golang tests#53
Conversation
this replaces the current hide functionality
Polls that are hidden really shouldn't be revealed
actually add go.mod to the image
Till -> Untill
this time I :set spell
|
I'll fix the conflicts before this goes for merge, but does this need to get into dev imminently? |
|
Also: it's rebase one or the other, given this runs gofmt |
mxmeinhold
force-pushed
the
mom/testing
branch
from
f510452 to
eb77dad
Compare
|
Oh, actually, it's gonna be a mess regardless, because someone disabled merge commits |
Yeah, I'm not sure why this is
No, just curious as to why it should go into #52 since it feels separate from hiding things |
|
It is based on the CI setup in that PR. It does not need to be merged into that PR, but it includes the commits from that PR, so it should not go into mainline without commits from that PR |
BigSpaceships
left a comment
BigSpaceships
left a comment
There was a problem hiding this comment.
lgtm, most of it is just refactored and I can't see any difference and I trust max's ability to copy and paste, also test cases look right
There was a problem hiding this comment.
Tests pass, though there are really only a few (this is setting up for more tests, so I understand this). There are also a lot of comments. Yippee! I love comments. I agree that it can stick with the CI PR in #52 (though really, I think CI/test PRs and feature PRs should be separate)
mxmeinhold
force-pushed
the
mom/hide-progress
branch
from
bd3ce79 to
321f2e1
Compare
|
oh that auto delete closed this huh |
3 participants
No description provided.